Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setMaxThreads in http-wordpress-brute NSE script #627

Closed
wants to merge 1 commit into from
Closed

Fix setMaxThreads in http-wordpress-brute NSE script #627

wants to merge 1 commit into from

Conversation

Nukesor
Copy link

@Nukesor Nukesor commented Dec 28, 2016 •
edited

The setMaxThreads function requires an Int as parameter as the nselib/brute.lua will die, if we provide a string: https://github.com/nmap/nmap/blob/master/nselib/brute.lua#L1188

The script sets the max threads number after the Engine initialization, but uses the parameter string without converting it to an int.

@dmiller-nmap
Copy link

Thanks! I found several other places where this could cause problems, so I fixed those as well and credited you. I want point out that http-form-brute should be capable of brute-forcing Wordpress installations since 7.10. I'd appreciate your feedback on any problems you find in that script.

@nmap-bot nmap-bot closed this in 3961450 Dec 28, 2016
suraj51k pushed a commit to suraj51k/nmap that referenced this pull request Jan 31, 2017
@bonsaiviking @suraj51k
Convert brute threads script-args to number. Closes nmap#627
dc2b58d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nukesor @dmiller-nmap