Replaced function packlen with packsize in knx-gateway-discover script #2727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script fails because the function packlen does not exist.
This was referenced Oct 23, 2023
|
Ok
Vào 12:19, Th 2, 23 thg 10, 2023 f0rw4rd ***@***.***> đã viết:
… This a patch for a bug in the knx-gateway-discover script and it fails
because the function packlen does not exists in Line 96.
Nmap version used:
Nmap version 7.94 ( https://nmap.org )
Platform: x86_64-pc-linux-gnu
Compiled with: liblua-5.4.6 openssl-3.1.2 libssh2-1.11.0 libz-1.3 libpcre-8.45 libpcap-1.10.4 nmap-libdnet-1.12 ipv6
Compiled without:
Available nsock engines: epoll poll select
The fix was tested against a KNX setup:
NSE: Starting knx-gateway-discover.
NSE: Finished knx-gateway-discover.
Completed NSE at 07:13, 3.20s elapsed
Pre-scan script results:
| knx-gateway-discover:
| 172.1.0.193:
| Header:
| Header length: 6
| Protocol version: 16
| Service type: SEARCH_RESPONSE (0x0202)
| Total length: 78
| Body:
| HPAI:
| Protocol code: 01
| IP address: 172.1.0.193
| Port: 3671
| DIB_DEV_INFO:
| Description type: Device Information
| KNX medium: KNX TP1
| Device status: 00
| KNX address: 15.15.15
| Project installation identifier: 0000
| Decive serial: 00010052178f
| Multicast address: 0.0.0.0
| Device MAC address: 00:0e:8c:00:b9:d7
| Device friendly name: IP-Schnittstelle Secure
| DIB_SUPP_SVC_FAMILIES:
| KNXnet/IP Core version 2
| KNXnet/IP Device Management version 2
| KNXnet/IP Tunnelling version 2
|_ KNXnet/IP Remote Configuration and Diagnosis version 1
NSE: Script Post-scanning.
NSE: Starting runlevel 1 (of 1) scan.
Initiating NSE at 07:13
Completed NSE at 07:13, 0.00s elapsed
------------------------------
You can view, comment on, or merge this pull request online at:
#2727
Commit Summary
- 1f3e84f
<1f3e84f>
Replaced function packlen with packsize in knx-gateway-discover
File Changes
(1 file <https://github.com/nmap/nmap/pull/2727/files>)
- *M* scripts/knx-gateway-discover.nse
<https://github.com/nmap/nmap/pull/2727/files#diff-123c18abeecbd9a5429dc69c13f05f23214a45a6fc67a36fbd2fa86f531efa18>
(2)
Patch Links:
- https://github.com/nmap/nmap/pull/2727.patch
- https://github.com/nmap/nmap/pull/2727.diff
—
Reply to this email directly, view it on GitHub
<#2727>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZN5HY4HZJTSYW7P4ANQGP3YAX45XAVCNFSM6AAAAAA6LPMOE6VHI2DSMVQWIX3LMV43ASLTON2WKOZRHE2TMMZXGIYTKOA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Committed as r38737. Thank you for contributing to Nmap! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a patch for a bug in the knx-gateway-discover script and it fails because the function packlen does not exists in Line 96.
Nmap version used:
The fix was tested against a KNX setup: