Fix name resolution for socks4 proxy. #1214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously client didn't try to resolve hostname prior to sending request to proxy. It violates SOCKS4a specification which says DSTIP should be set to .X if client cannot resolve the destination host and may be problematic in some environments. This behaviour can be overriden with --nodns option (to force client to use socks4a extention); Bug-Url: https://bugzilla.redhat.com/1573148
|
The change, if I understand it correctly, would substantially break backwards compatibility. Namely, I can currently connect like this: which performs remote DNS lookup of which will fail, because I believe that a better approach could be to decouple hostname resolution of proxy destinations from all the other resolutions, which need to be inherently done locally. Could you please take a look at #1439 and let me know if it would meet your needs? |
|
Ability to control DNS resolution implemented in r37586. Thank you for raising up the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously client didn't try to resolve hostname prior to sending
request to proxy. It violates SOCKS4a specification which says
DSTIP should be set to .X if client cannot resolve the destination
host and may be problematic in some environments.
This behaviour can be overriden with --nodns option (to force client to
use socks4a extention);