fix bad argument exception when using smb-ls script #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The difference is a single slash ('/') will do full division return a floating point number. A double slash ('//') will drop the decimal returning a whole integer. Based on how it is being used I'm guessing the double slash, dropping the decimals values, is correct. |
|
@sstelfox thank you for the clarification :) |
|
Also tested this with latest stable update, smb-ls fails, downloaded Dallas's modified smb.lua and replaced, retested, everything works! |
|
bump |
|
I will look into this today, your solution seems correct. Thanks for all the details. |
|
@cldrn bump, did you get a chance to look at this? |
suraj51k
pushed a commit
to suraj51k/nmap
that referenced
this pull request
Jan 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating to nmap7.25BETA2 from nmap7.25BETA1 I started consistently encountering a bad date argument exception when trying to run the smb-ls script on a target
On line 1068 an additional / was added to the expression in commit "Merge branch 'nse-lua53'"
Adding a / to the expression on line 2808 to match line 1068 fixes the issue.
Alternatively, removing the newly added / to the expression on line 1068 should also fix it.
I do not know which solution is preferred/correct.