Bugfix for non-HTTP ports (xmlrpc-methods.nse) #244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever the script runs on a non HTTP port (like a sshd running on TCP/443), this script returns an ERROR because it references response.body which is not set in such a case.
|
Thanks for catching this. I'm handling it by checking for response, response.body, and response.status immediately after the http.post and bailing out early if any of them is false. Watch for linked commit to close this PR soon. |
qha
pushed a commit
to qha/nmap
that referenced
this pull request
Dec 16, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever the script runs on a non HTTP port (like a sshd running on
TCP/443), this script returns an ERROR because it references
response.body which is not set in such a case.