Mitigate nil values and change strjoin library #1720
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your patch for the stale references to |
|
The issue of arithmetic on a potentially nil |
nmap-bot
pushed a commit
that referenced
this pull request
Sep 1, 2019
nmap-bot
pushed a commit
that referenced
this pull request
Sep 1, 2019
|
The fix for ID Authority possibly being nil seems incorrect. See commit r37724 (ef2825b) for an alternate assessment. |
|
Okay, thanks a lot for the fast response to the changes! |
|
Thank your for finding the bugs and submitting patches. They are definitely appreciated. I will tentatively close this issue; we can always reopen it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
msrpc.luaandmsrpctypes.luawere giving off errors when running the command:nmap -Pn -p445 --script smb-brute domain.com -d.The errors in the
msrpctypes.luascript came from the migration from bin.pack and bin.unpack to string.pack and string.unpack. The former acceptednilvalues for as arguments and we did not do any arithmetic to determine whether the data is enough to extract an object. Now, however, we need to manually check whether the data is enough and can no longer passnilvalues as arguments. The fix just initializes uninitialized variables to 1 which is the default for Lua.The errros in the
msrpc.luascript came from the wrong library referencing for the strjoin method used in some internal methods. I managed to find it in thestringauxlibrary, not in thestdnse.