Fix to prevent connections to get terminated while still on going #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know how people could use it before this
|
Thanks for the patch! This error is not mentioned in the "Return value" section of the documentation for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know how people could use it before this commit.
Connections get finished whenever the result from
WaitForMultipleObjectserrors toERROR_IO_INCOMPLETE.Testing:
Listen with:
ncat.exe -lvp 4444 --sslConnect with:
ncat.exe 127.0.0.1 4444 -e cmd.exe --ssl -v.Run any command (i.e. dir) and it will close the connection.
Standard error is reported in the client and not in the server but I'll open a ticket to fix that.
Cheers
EDIT: stderr issue: #1373