Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table input for http-grep.match arg #1158

Closed
wants to merge 1 commit into from

Conversation

hansbogert
Copy link

Checking the http-grep argument is now accurately against a table string instead table keyword.
The index for the matching table was also incorrect due to erroneous extra spaces.

Checking the http-grep argument is now accurately against a table string instead table keyword. 
The index for the matching table was also incorrect due to erroneous extra spaces.
@nmap-bot nmap-bot closed this in 02e3add Mar 28, 2018
@hansbogert
Copy link
Author

hansbogert commented Apr 9, 2018

  1. A little feedback wouldn't hurt
  2. You merge in my changes without giving due credit (Unless the changelog is updated later in the process, but I don't see it)
  3. You only apply half of the patch? The whitespace change really makes a difference.

@dmiller-nmap
Copy link

@hansbogert I'm sorry, the commit in question wasn't complete. I split the change into the two separate issues it fixes because I found multiple instances of type(x) being compared to non-strings, but time intervened and the whitespace part and changelog credit were never applied. I've fixed it in an upcoming commit. Thanks for your help!

nmap-bot pushed a commit that referenced this pull request Apr 10, 2018
@hansbogert hansbogert deleted the patch-1 branch April 17, 2018 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants