Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make http-fetch prepend host:port directory to destination #1099

Closed
dmiller-nmap opened this issue Jan 8, 2018 · 3 comments
Closed

Make http-fetch prepend host:port directory to destination #1099

dmiller-nmap opened this issue Jan 8, 2018 · 3 comments

Comments

@dmiller-nmap
Copy link

http-fetch downloads files like wget, but although it takes a destination directory script-arg, it doesn't keep separate subdirectories for separate targets. We should automatically create a host:port directory below the destination and keep the files in there.

@aniketp
Copy link

aniketp commented Jan 8, 2018

@dmiller-nmap I'll work on it.

aniketp added a commit to aniketp/nmap that referenced this issue Jan 8, 2018
This commit fixes nmap#1099 on creation of separate sub-directories for each target in the form of (host:port)
aniketp added a commit to aniketp/nmap that referenced this issue Jan 8, 2018
This commit fixes nmap#1099 on creation of separate sub-directories for each target in the form of (host:port)
@aniketp
Copy link

aniketp commented Jan 8, 2018

@dmiller-nmap Fixed in #1100 . Please have a look.

NK-Nikunj added a commit to NK-Nikunj/nmap that referenced this issue Jan 9, 2018
This commit attempts to fix the issue nmap#1099 wrt to creation of separate sub-directories for each target.
This commit will now enable the user to download to destination/target-name_or_ip/port:port_number.
@NK-Nikunj
Copy link

Hello @dmiller-nmap

I have been using nmap for quite some time(off-course for white hat purpose). I am new to open source community and would like to contribute.

NK-Nikunj added a commit to NK-Nikunj/nmap that referenced this issue Jan 10, 2018
This commit attempts to fix the issue nmap#1099 wrt to creation of separate sub-directories for each target.
This commit will now enable the user to download to destination/target-name_or_ip/port:port_number.
NK-Nikunj added a commit to NK-Nikunj/nmap that referenced this issue Jan 10, 2018
This commit attempts to fix the issue nmap#1099 wrt to creation of separate sub-directories for each target.
This commit will now enable the user to download to destination/target-name_or_ip/port-port_number.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants