Fix #1016 Script to extract iLO server info from /xmldata?item=all #1082
Conversation
scripts/ilo-info.nse
Outdated
| local slaxml = require "slaxml" | ||
| local stdnse = require "stdnse" | ||
|
|
||
| portrule = function(host,port) |
There was a problem hiding this comment.
You should be able to use the shortport.http portrule for this script.
scripts/ilo-info.nse
Outdated
| info['cUUID '] = getTag(dom,"cUUID") | ||
| info['ILOType '] = getTag(dom,"PN") | ||
| info['ILOFirmware'] = getTag(dom,"FWRI") | ||
| info['Serial No '] = getTag(dom,"SN") |
There was a problem hiding this comment.
Even though justified text fields look nice, they throw off machine parsing in XML. Please do not pad output with whitespace.
scripts/ilo-info.nse
Outdated
|
|
||
| action = function(host,port) | ||
| local response = http.get(host,port,"/xmldata?item=all") | ||
| if response["status"] == "404" |
There was a problem hiding this comment.
Shouldn't this be if response.status ~= "200"? Non-iLO servers may return other status codes like 401, 403, etc.
scripts/ilo-info.nse
Outdated
| return | ||
| end | ||
| local domtable = slaxml.parseDOM(response["body"],{stripWhitespace=true}) | ||
| return stdnse.format_output(true, parseXML(domtable)) |
There was a problem hiding this comment.
The stdnse.format_output function is deprecated. Please use NSE structured output instead.
scripts/ilo-info.nse
Outdated
| --| Mac Address : 11:22:33:44:55:66 | ||
| --| Description : iLO 4 | ||
| --| IP Address : Unknown | ||
| --|_ Status : Disabled |
There was a problem hiding this comment.
An example of a Lua table that represents this info for structured output (see other notes) would be:
{
["ILO Type"] = "Integrated Lights-Out 4 (iLO 4)",
["Serial"] = "ILOXXXXXXXXXXX",
["NICs"] = {
["NIC 1"] = {
["MAC Address"] = "12:34:56:78:9a:bc",
["Status"] = "OK"
},
["NIC 2"] = {...},
},
}Ensure that the elements are displayed in the same order every time by using output_table structures.
scripts/ilo-info.nse
Outdated
| count = count + 1 | ||
| for k,m in ipairs(n.kids) do | ||
| if m.name == "DESCRIPTION" then | ||
| info["Description"] = m.kids[1].value |
There was a problem hiding this comment.
If a field (usually IPADDR) is empty, this will crash, since m.kids[1] is nil. Check that #m.kids >= 1 and that m.kids[1].type == "text" before checking m.name.
|
@dmiller-nmap I've made the requested changes. Thanks for reviewing my first script. |
|
Hi there. I wrote a script to analyse the XML output of this script. You can find it here. |
|
@dmiller-nmap can you merge the changes. This is my first contribution to nmap :D |
|
@dmiller-nmap your requests seem to have been addressed. Is this now ready for merging ? |
|
Ping on @tpltnt 's behalf. This looks like a very useful NSE script, I'd love to see it make mainline. |
|
@dmiller-nmap pls consider merging |
|
ping on behalf of @jeffmcjunkin and @rajeevrmenon97 |
|
I was really excited to start contributing to nmap. This was my first PR. I'm really disappointed at this not getting accepted and that's why I stopped working on this project. |
|
I can see your point @rajeevrmenon97 |
|
Hello, After testing and applying Nmap's coding standards (https://secwiki.org/w/Nmap/Code_Standards) I committed your script in r37613. We always appreciate the help and even the needed nudges from time to time. As you probably know, lately the development efforts have been focused on NPcap but this does not mean NSE is forgotten. Keep contributing and I will try to help as much as time allows me! |
|
Thanks for committing my script. I made this NSE almost a year ago. I'll start looking into NPcap. |
|
What do you mean by committed to r37613? When will it be merged? |
|
Thanks @cldrn . And yes, Npcap has been taking almost all of our time lately, but we're super close to the big 1.0 release and then we're going to turn our attention back to Nmap proper. Of course all of our Npcap work is done to benefit Nmap too. It's just low-level infrastructure rather than shiny new user-visible features. |
I'm new to nmap. I'm trying to start contributing by attempting the fix of an issue labeled easy. This is my first NSE script. I am trying to resolve issue #1016 . This script extracts hardware info on HP iLO board from /xmldata?item=all.